Skip to content

Implement MTCLog AddTBS HTTP handler - #1080

Merged
phbnf merged 2 commits into
transparency-dev:mainfrom
phbnf:mtc-addtbs-split
Jul 30, 2026
Merged

Implement MTCLog AddTBS HTTP handler#1080
phbnf merged 2 commits into
transparency-dev:mainfrom
phbnf:mtc-addtbs-split

Conversation

@phbnf

@phbnf phbnf commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Towards #945.

This PR also make MTCLogEntry fields private, and introduces a New function to create these objects.
We could, in a followup PR move the extension checks to it.. they are not used at the moment, so this this is not super important.

@phbnf
phbnf requested a review from AlCutter July 29, 2026 13:38
@phbnf
phbnf marked this pull request as ready for review July 29, 2026 13:38
@phbnf
phbnf requested a review from a team as a code owner July 29, 2026 13:38
@phbnf
phbnf force-pushed the mtc-addtbs-split branch from 409d2e1 to af8a99f Compare July 29, 2026 13:43
Comment thread cmd/mtc/log/mtc.go Outdated
// to build a standalone certificate.
type AddTBSRsp struct {
Index uint64 `json:"index"`
MTCProof MTCProof `json:"mtcproof"`

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mtcProof to match camel-case style on the request body JSON?

@phbnf
phbnf force-pushed the mtc-addtbs-split branch from af8a99f to 6923b66 Compare July 30, 2026 14:27
@phbnf
phbnf force-pushed the mtc-addtbs-split branch from 6923b66 to 7520def Compare July 30, 2026 14:37
@phbnf
phbnf merged commit 5372095 into transparency-dev:main Jul 30, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants